Discussion:
[PATCH][libva-intel-driver] vpp chroma-formats: report supported chroma formats for vpp
(too old to reply)
Daniel Charles
2016-10-12 22:58:20 UTC
Permalink
vpp to report the chroma formats according to what's allowed
by vaCreateSurfaces2

Signed-off-by: Daniel Charles <***@intel.com>
---
src/i965_drv_video.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c
index 3a33356..e092a1c 100644
--- a/src/i965_drv_video.c
+++ b/src/i965_drv_video.c
@@ -847,8 +847,11 @@ i965_get_default_chroma_formats(VADriverContextP ctx, VAProfile profile,
break;

case VAProfileNone:
- if(HAS_VPP_P010(i965))
+ if(HAS_VPP_P010(i965))
chroma_formats |= VA_RT_FORMAT_YUV420_10BPP;
+
+ if(HAS_VPP(i965))
+ chroma_formats |= VA_RT_FORMAT_YUV422 | VA_RT_FORMAT_RGB32;
break;

case VAProfileVP9Profile0:
--
2.5.5
Xiang, Haihao
2016-10-13 08:09:42 UTC
Permalink
Post by Daniel Charles
vpp to report the chroma formats according to what's allowed
by vaCreateSurfaces2
---
 src/i965_drv_video.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c
index 3a33356..e092a1c 100644
--- a/src/i965_drv_video.c
+++ b/src/i965_drv_video.c
@@ -847,8 +847,11 @@ i965_get_default_chroma_formats(VADriverContextP
ctx, VAProfile profile,
         break;
 
- if(HAS_VPP_P010(i965))
+     if(HAS_VPP_P010(i965))
please use the same indentation used in this file.
Post by Daniel Charles
             chroma_formats |= VA_RT_FORMAT_YUV420_10BPP;
+
+        if(HAS_VPP(i965))
+            chroma_formats |= VA_RT_FORMAT_YUV422 |
VA_RT_FORMAT_RGB32;
         break;
 
Charles, Daniel
2016-10-13 16:47:57 UTC
Permalink
I sent a new version, pardon the PEBKAC. Is there a particular
indentation scheme to follow?
--
Daniel.
Post by Daniel Charles
vpp to report the chroma formats according to what's allowed
by vaCreateSurfaces2
---
src/i965_drv_video.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c
index 3a33356..e092a1c 100644
--- a/src/i965_drv_video.c
+++ b/src/i965_drv_video.c
@@ -847,8 +847,11 @@ i965_get_default_chroma_formats(VADriverContextP
ctx, VAProfile profile,
break;
- if(HAS_VPP_P010(i965))
+ if(HAS_VPP_P010(i965))
please use the same indentation used in this file.
Post by Daniel Charles
chroma_formats |= VA_RT_FORMAT_YUV420_10BPP;
+
+ if(HAS_VPP(i965))
+ chroma_formats |= VA_RT_FORMAT_YUV422 |
VA_RT_FORMAT_RGB32;
break;
Xiang, Haihao
2016-10-17 00:58:40 UTC
Permalink
Post by Charles, Daniel
I sent a new version, pardon the PEBKAC. Is there a particular
indentation scheme to follow?
The original file uses 4 spaces (not a tab) for indentation, please use
the same indentation in the patch. Sometimes a patch was merged without
checking the indentation, which makes the code harder to read.

Thanks
Haihao

Loading...